feat: copy #10
Open
feat: copy #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianxiaoBai
reviewed
Apr 24, 2023
src/components/JsonView.tsx
Outdated
| if (Array.isArray(sourceData)) { | ||
| sourceData.splice(+key, 0, value) | ||
| } else { | ||
| Reflect.set(sourceData, key + '副本', Reflect.get(sourceData, key)) |
Owner
There was a problem hiding this comment.
- 这里把 "副本" 改成 "copy" 吧
- 这还有个小问题就是只能新增一个，不能连续新增，新增时 key 的副本也会进行自增，如 key copy 1/ key copy
Contributor
Author
There was a problem hiding this comment.
由于field文本框宽度为100px，此处修改为key copy 1 - key copy n 会造成key过长不方便阅读，所以我改为了key-n这种类型，去掉了copy，并且复制出来的数据禁止了的copy功能
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
如果可以合入辛苦改一下example图片和README